Skip to content

gh-92348: Add quotes to support building on Windows with spaces in directory name#94925

Merged
zooba merged 1 commit intopython:mainfrom
zooba:gh92348
Jul 17, 2022
Merged

gh-92348: Add quotes to support building on Windows with spaces in directory name#94925
zooba merged 1 commit intopython:mainfrom
zooba:gh92348

Conversation

@zooba
Copy link
Copy Markdown
Member

@zooba zooba commented Jul 17, 2022 •
edited by bedevere-bot
Loading

@zooba zooba added OS-windows needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 17, 2022
@zooba zooba requested a review from a team as a code owner July 17, 2022 13:30
@zooba zooba merged commit 5c19dda into python:main Jul 17, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 17, 2022

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@zooba zooba deleted the gh92348 branch July 17, 2022 14:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2022
@zooba @miss-islington
pythongh-92348: Add quotes to support building on Windows with spaces…
98aa820 
… in directory name (pythonGH-94925)

(cherry picked from commit 5c19dda)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 17, 2022
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 17, 2022

GH-94927 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 17, 2022

Sorry, @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5c19ddab65f91d190ec94c494e95c5d551a45efc 3.10

miss-islington added a commit that referenced this pull request Jul 17, 2022
@miss-islington @zooba
gh-92348: Add quotes to support building on Windows with spaces in di…
7bca87d 
…rectory name (GH-94925)

(cherry picked from commit 5c19dda)

Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba zooba removed the needs backport to 3.10 only security fixes label Jul 17, 2022
@zooba
Copy link
Copy Markdown
Member Author

zooba commented Jul 17, 2022

Underlying code isn't in 3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zooba zooba

Labels

OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zooba @miss-islington @bedevere-bot