Skip to content

gh-67707: support partials in asyncio.iscoroutinefunction #94907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
graingert wants to merge 4 commits into from
Closed

gh-67707: support partials in asyncio.iscoroutinefunction #94907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c0cf0a
support partials in asyncio.iscoroutinefunction
graingert Jul 16, 2022
99c3e0d
Update Lib/test/test_asyncio/test_tasks.py
graingert Jul 16, 2022
d398f4b
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 16, 2022
879299a
import functools for _unwrap_partial
graingert Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Lib/asyncio/coroutines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
__all__ = 'iscoroutinefunction', 'iscoroutine'

import collections.abc
import functools
import inspect
import os
import sys
Expand All @@ -19,8 +20,11 @@ def _is_debug_mode():

def iscoroutinefunction(func):
"""Return True if func is a decorated coroutine function."""
return (inspect.iscoroutinefunction(func) or
getattr(func, '_is_coroutine', None) is _is_coroutine)
return (
inspect.iscoroutinefunction(func)
or getattr(func, '_is_coroutine', None) is _is_coroutine
Copy link
Contributor Author

@graingert graingert Jul 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to both check the attribute and unwrap the partial so it can support code that worked around this issue by doing:

        def sync_fn():
            pass

        partial_sync_fn = functools.partial(sync_fn)
        partial_sync_fn._is_coroutine = asyncio.coroutines._is_coroutine

or getattr(functools._unwrap_partial(func), "_is_coroutine", None) is _is_coroutine
)


# Prioritize native coroutine check to speed-up
Expand Down
20 changes: 19 additions & 1 deletion Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1644,9 +1644,27 @@ def fn1():
yield
self.assertFalse(asyncio.iscoroutinefunction(fn1))

async def fn2():
def fn2():
pass

fn2._is_coroutine = asyncio.coroutines._is_coroutine

self.assertTrue(asyncio.iscoroutinefunction(fn2))
self.assertTrue(asyncio.iscoroutinefunction(functools.partial(fn2)))
self.assertTrue(asyncio.iscoroutinefunction(functools.partial(functools.partial(fn2))))

async def async_fn():
pass

self.assertTrue(asyncio.iscoroutinefunction(async_fn))

def sync_fn():
pass

partial_sync_fn = functools.partial(sync_fn)
partial_sync_fn._is_coroutine = asyncio.coroutines._is_coroutine

self.assertTrue(asyncio.iscoroutinefunction(partial_sync_fn))

self.assertFalse(asyncio.iscoroutinefunction(mock.Mock()))
self.assertTrue(asyncio.iscoroutinefunction(mock.AsyncMock()))
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-07-16-23-53-32.gh-issue-67707.GDOo7t.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
support partials of asyncio coroutine marked functions in asyncio.iscoroutinefunction