Skip to content

bpo-34011: Fixes missing venv files and other tests#9458

Merged
zooba merged 6 commits into
python:masterfrom
zooba:bpo-34011
Sep 20, 2018
Merged

bpo-34011: Fixes missing venv files and other tests#9458
zooba merged 6 commits into
python:masterfrom
zooba:bpo-34011

Conversation

@zooba

@zooba zooba commented Sep 20, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Mostly related to test fixes for when Python is running outside of a regular build directory. The only product impact is for bpo-34011

https://bugs.python.org/issue34011

@zooba zooba added tests Tests in the Lib/test dir skip news labels Sep 20, 2018
@zooba zooba changed the title bpo-34011 Fixes missing venv files and other tests bpo-34011: Fixes missing venv files and other tests Sep 20, 2018
vsajip
vsajip reviewed Sep 20, 2018
View reviewed changes

@vsajip vsajip left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in venv/__init__.py seems OK to me. I thought the venv tests worked when I ran them with an installed Python (you might remember some discussion back in July on Zulip about trying to build a WiX installer for Python - that was to test this issue using an installed Python). Not sure what I missed there.

@zooba
zooba requested a review from a team as a code owner September 20, 2018 18:32
@zooba

zooba commented Sep 20, 2018

Copy link
Copy Markdown
Member Author

@vsajip If you put Python on PATH when you installed, then it would work. But if you don't select that option, it can't find python38.dll automatically.

@zooba

zooba commented Sep 20, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

And I don't follow Zulip, so you can't rely on me noticing any conversations on there at all (ah okay, I was actually involved in this one :) )

@vsajip

vsajip commented Sep 20, 2018

Copy link
Copy Markdown
Member

@vsajip If you put Python on PATH when you installed, then it would work. But if you don't select that option, it can't find python38.dll automatically.

Ah, right, that could well explain it.

@zooba
zooba merged commit f14c28f into python:master Sep 20, 2018
@zooba
zooba deleted the bpo-34011 branch September 20, 2018 20:38
zooba added a commit to zooba/cpython that referenced this pull request Sep 20, 2018
@zooba
Fixes tests requiring extra environment values on Windows (pythonGH-9458
c66cd52 
)
@pablogsal

pablogsal commented Nov 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

This buildbot is failing when raising when creating subprocess.CalledProcessError:

https://buildbot.python.org/all/#/builders/40/builds/1135/steps/3/logs/stdio

test_defaults (test.test_venv.BasicTest) ... ok
test_executable (test.test_venv.BasicTest) ... ok
test_executable_symlinks (test.test_venv.BasicTest) ... skipped 'Needs symlinks'
test_isolation (test.test_venv.BasicTest) ... ok
test_overwrite_existing (test.test_venv.BasicTest) ... ok
test_prefixes (test.test_venv.BasicTest) ... ok
test_prompt (test.test_venv.BasicTest) ... ok
test_symlinking (test.test_venv.BasicTest) ... skipped 'Needs symlinks'
test_unicode_in_batch_file (test.test_venv.BasicTest) ... ERROR
test_unoverwritable_fails (test.test_venv.BasicTest) ... ok
test_upgrade (test.test_venv.BasicTest) ... ok
test_devnull (test.test_venv.EnsurePipTest) ... ok
test_explicit_no_pip (test.test_venv.EnsurePipTest) ... ok
test_no_pip_by_default (test.test_venv.EnsurePipTest) ... ok
test_with_pip (test.test_venv.EnsurePipTest) ... ok
======================================================================
ERROR: test_unicode_in_batch_file (test.test_venv.BasicTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_venv.py", line 302, in test_unicode_in_batch_file
    out, err = check_output(
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_venv.py", line 37, in check_output
    raise subprocess.CalledProcessError(
TypeError: __init__() takes from 3 to 5 positional arguments but 6 were given
----------------------------------------------------------------------

I will prepare a PR fixing this

@pablogsal

pablogsal commented Nov 7, 2018

Copy link
Copy Markdown
Member

More Windows buildbots are failing:

https://buildbot.python.org/all/#/builders/32/builds/1706
https://buildbot.python.org/all/#/builders/3/builds/1633

@pablogsal

pablogsal commented Nov 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@zooba @vsajip There may be more problems with this Pull Request than just the problem above, can you take a look at the buildbots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip left review comments

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @vsajip @pablogsal @the-knights-who-say-ni @bedevere-bot