Skip to content

GH-94329: Don't raise on excessive stack consumption#94421

Merged
markshannon merged 4 commits into
python:mainfrom
faster-cpython:no-stack-size-assert
Jun 30, 2022
Merged

GH-94329: Don't raise on excessive stack consumption#94421
markshannon merged 4 commits into
python:mainfrom
faster-cpython:no-stack-size-assert

Conversation

@markshannon

@markshannon markshannon commented Jun 29, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

We want the compiler to produce code that doesn't use excessive amounts of stack, but we shouldn't limit what we can compile.

This PR allows code like x0, x1, ..., x4000 = t to compile and run correctly.

For 3.12 we want to compile the above code in a way that doesn't use too much stack, but for now let's just accept that we need a lot of stack.

@markshannon markshannon added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 29, 2022
iritkatriel
iritkatriel reviewed Jun 30, 2022
View reviewed changes
Comment thread Python/compile.c
@markshannon markshannon merged commit b152bf4 into python:main Jun 30, 2022
@miss-islington

miss-islington commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b152bf448b321e3a4c0a7280e0b608840f5ac661 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2022
@markshannon @miss-islington
pythonGH-94329: Don't raise on excessive stack consumption (pythonGH-…
9d8cbb2 
…94421)

(cherry picked from commit b152bf4)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot

bedevere-bot commented Jun 30, 2022

Copy link
Copy Markdown

GH-94446 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 30, 2022
@markshannon markshannon removed the needs backport to 3.10 only security fixes label Jun 30, 2022
markshannon added a commit to faster-cpython/cpython that referenced this pull request Jun 30, 2022
@markshannon
pythonGH-94329: Don't raise on excessive stack consumption (pythonGH-…
14681d0 
…94421)

(cherry picked from commit b152bf4)
markshannon pushed a commit that referenced this pull request Jun 30, 2022
@miss-islington
GH-94329: Don't raise on excessive stack consumption (GH-94421) (GH-9…
f58c366 
…4446)

(cherry picked from commit b152bf4)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
@markshannon @gvanrossum
pythonGH-94329: Don't raise on excessive stack consumption (pythonGH-…
2d55fea 
…94421)
pablogsal pushed a commit that referenced this pull request Jul 11, 2022
@markshannon
[3.10] GH-94329: Don't raise on excessive stack consumption (GH-94421) (
b87d03d 
#94448)
@DanielNoord DanielNoord mentioned this pull request Jul 13, 2022
Closed
@markshannon markshannon deleted the no-stack-size-assert branch September 26, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@markshannon markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon @miss-islington @bedevere-bot @iritkatriel