Skip to content

Link to the devguide's PR guidelines #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 1 commit into from
Mar 31, 2017
Merged

Link to the devguide's PR guidelines #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/CONTRIBUTING.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@ everything from how to build the code to submitting a pull request. There are
also suggestions on how you can most effectively help the project.

Please be aware that our workflow does deviate slightly from the typical GitHub
project. Issues are tracked at https://bugs.python.org/ and should be mentioned
in pull requests using the format of ``bpo-12345`` . If your pull request is in
response to a specific issue then please mention it in the title,
e.g. “bpo-12345: fix comment in tokenizer.c”.
project. Details on how to properly submit a pull request are covered in

@Mariatta Mariatta Mar 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would omit the word 'properly' . 🤔

@Mariatta Mariatta Mar 31, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm too picky. It's up to you. Looks good overall. :) Thanks.

@brettcannon brettcannon Mar 31, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I put that word in to make sure people read it, otherwise submitting a PR without following those guidelines won't lead to your PR being accepted outright, hence not done properly.

`Lifecycle of a Pull Request <https://cpython-devguide.readthedocs.io/pullrequest.html>`_.

If you are making a code contribution or large documentation contribution,
please feel free to add yourself to the ``Misc/ACKS`` file alphabetically.
Expand Down