gh-93124: Fix typos in comments#93125
Merged
miss-islington merged 3 commits intopython:mainfrom May 25, 2022
Merged
Conversation
Akuli
requested review from
1st1,
Fidget-Spinner,
JelleZijlstra,
asvetlov,
gvanrossum,
lysnikolaou and
pablogsal
as code owners
gvanrossum
approved these changes
May 23, 2022
Fidget-Spinner
approved these changes
May 23, 2022
JelleZijlstra
approved these changes
May 23, 2022
| results1.append(True) | ||
| else: | ||
| # here drained task ouside the barrier | ||
| # here drained task outside the barrier |
Member
There was a problem hiding this comment.
Not entirely sure what this comment is trying to say
rhettinger
approved these changes
May 25, 2022
Contributor
|
Closing and reopening so that the bots will rerun. |
Contributor
|
@Akuli: Status check is done, and it's a failure ❌ . |
Contributor
|
Status check is done, and it's a success ✅ . |
Contributor
|
Status check is done, and it's a success ✅ . |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Status check is done, and it's a success ✅ . |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Status check is done, and it's a success ✅ . |
Member
|
(What's with the many Miss-I interactions here?) |
Contributor
Author
|
No idea. The bot just posted lots of comments when I pushed a new commit :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93124
Automerge-Triggered-By: GH:rhettinger