GH-93115: Fix error code tests in test_sqlite3.test_dbapi #93116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They used sqlite.version_info (2.6.0 for the past 12 years) rather than .sqlite_version_info. Also, the last statement raised a NameError.
The-Compiler
requested review from
berkerpeksag and
erlend-aasland
as code owners
erlend-aasland
approved these changes
May 23, 2022
Contributor
|
Thanks for the report and fix, and thanks for your interest in improving CPython! |
Contributor
|
Thanks @The-Compiler for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-93128 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2022
…ythonGH-93116) (cherry picked from commit d5f0dd1) Co-authored-by: Florian Bruhin <me@the-compiler.org>
miss-islington
added a commit
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They used sqlite.version_info (2.6.0 for the past 12 years) rather than .sqlite_version_info. Also, the last statement raised a NameError.
Runs fine for me on Archlinux with sqlite 3.38.5.
Closes #93115.