Skip to content

Conversation

@The-Compiler
Copy link
Contributor

Regressed in 40348ac (GH-28405, v3.11.0a1) - cc @serhiy-storchaka.

(Also regressed in Lib/test/test_importlib/test_locks.py, but there it was already fixed in 2b16a08 by @tiran)

I believe this is simple enough to not need an issue/news-entry, but let me know if you disagree!

(Found by running flake8 over Lib/ out of curiosity, see #93010 (comment))

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@miss-islington
Copy link
Contributor

Thanks @The-Compiler for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 25, 2022
@bedevere-bot
Copy link

GH-93208 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 25, 2022
@bedevere-bot
Copy link

GH-93209 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request May 25, 2022
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
miss-islington added a commit that referenced this pull request May 25, 2022
(cherry picked from commit 1971014)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants