Skip to content

gh-91731: Fix typo in pymacro.h#92618

Merged
pablogsal merged 2 commits intopython:mainfrom
pablogsal:fix_typo
May 10, 2022
Merged

gh-91731: Fix typo in pymacro.h#92618
pablogsal merged 2 commits intopython:mainfrom
pablogsal:fix_typo

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented May 10, 2022

No description provided.

@pablogsal pablogsal mentioned this pull request May 10, 2022
Merged
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 10, 2022

You should use gh-91731: rather than skipping the issue. You can add it when you merge the PR.

It seems like macOS also has build error with static_assert() :-( #91731 (comment)

vstinner
vstinner reviewed May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each time I saw the project name mentioned, it was written lower case.

@pablogsal pablogsal changed the title Fix typo in pymacro.h gh-91731: Fix typo in pymacro.h May 10, 2022
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented May 10, 2022

ou should use gh-91731: rather than skipping the issue. You can add it when you merge the 

Done :)

@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented May 10, 2022

It seems like macOS also has build error with static_assert() :-( #91731 (comment)

The never ending story :(

@pablogsal @vstinner
Update Include/pymacro.h
58642c8 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peeeerfect.

@pablogsal pablogsal merged commit 4e6da50 into python:main May 10, 2022
@pablogsal pablogsal deleted the fix_typo branch May 10, 2022 12:47
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 10, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 10, 2022

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4e6da502f42e3cbdffbe850833d2b04996232f0d 3.10

@pablogsal pablogsal added needs backport to 3.11 only security fixes and removed needs backport to 3.10 only security fixes labels May 10, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 10, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 10, 2022

Sorry @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4e6da502f42e3cbdffbe850833d2b04996232f0d 3.11

@pablogsal pablogsal added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 10, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 10, 2022

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 10, 2022

GH-92623 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@pablogsal @miss-islington
pythongh-91731: Fix typo in pymacro.h (pythonGH-92618)
74c4893 
* Fix typo in pymacro.h

* Update Include/pymacro.h

Co-authored-by: Victor Stinner <vstinner@python.org>

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 4e6da50)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington @pablogsal
gh-91731: Fix typo in pymacro.h (GH-92618)
6546af3 
* Fix typo in pymacro.h

* Update Include/pymacro.h

Co-authored-by: Victor Stinner <vstinner@python.org>

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 4e6da50)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @vstinner @miss-islington @bedevere-bot