Skip to content

Conversation

@AlexWaygood
Copy link
Member

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one minor textual nit (that wasn't introduced by this PR, but on a line touched by it), I checked over the importlib* docs and there indeed doesn't appear to be remaining references to unsupported versions, so LGTM.

One note, though—will only changes referring to Python versions that were unsupported at the time the backport target was released be backported? It seems a little odd to actively remove docs content that refers to versions supported at the time an older bugfix version just because an EoL date was later reached, as well as extra work.

It would seem to make more sense to have a consistent policy of just mentioning the Python versions supported as of the release of the target version, rather than going through and updating all the bugfix, pre-release and future docs at the moment an older version goes EoL, since otherwise up to 4 sets of docs need to be updated with every EoL on a rigid schedule, as opposed to just one set per release at any point between branching the previous release and the current release.

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@ambv
Copy link
Contributor

ambv commented May 19, 2022

Agreed with CAM, this should only get backported to 3.11 as Alex already edited.

@ambv ambv merged commit 70aa1b9 into python:main May 19, 2022
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-92979 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
…thon versions (pythonGH-92424)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 70aa1b9)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood deleted the importlib-docs branch May 19, 2022 15:53
ambv pushed a commit that referenced this pull request May 19, 2022
…ersions (GH-92424) (GH-92979)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 70aa1b9)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@jaraco
Copy link
Member

jaraco commented May 20, 2022

This change also needs to get backported to importlib_metadata. Done in python/importlib_metadata@c68e382f7c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants