Skip to content

gh-91803: Mock - fix error when using autospec methods with seal #92213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjw296 merged 12 commits into from
Nov 7, 2022
Merged

gh-91803: Mock - fix error when using autospec methods with seal #92213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
de27032
fix mocked autospec methods with seal
akulakov May 3, 2022
96c516a
add test
akulakov May 3, 2022
0a4a359
remove stray comment
akulakov May 3, 2022
7bda679
Merge branch 'main' into 91803-Fix-seal-with-autospec-methods
akulakov May 3, 2022
8f81849
add news
akulakov May 3, 2022
1e1f45d
Merge branch '91803-Fix-seal-with-autospec-methods' of github.com:aku…
akulakov May 3, 2022
6992de7
add comment
akulakov May 3, 2022
36a47d0
use child_klass instead of Mock
akulakov May 24, 2022
dfe90da
Merge branch 'main' into 91803-Fix-seal-with-autospec-methods
akulakov Jun 22, 2022
b1b12ab
Update Lib/test/test_unittest/testmock/testsealable.py
akulakov Jun 25, 2022
c535efb
expand unittest autospec seal() test
akulakov Jul 3, 2022
dbb8bf9
Merge branch 'main' into 91803-Fix-seal-with-autospec-methods
iritkatriel Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/test/test_unittest/testmock/testsealable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ def ban(self):
self.assertIsInstance(foo.Baz.baz, mock.NonCallableMagicMock)
self.assertIsInstance(foo.Baz.ban, mock.MagicMock)

# see gh-91803
self.assertIsInstance(foo.bar2(), mock.MagicMock)

self.assertEqual(foo.bar1(), 'a')
foo.bar1.return_value = 'new_a'
self.assertEqual(foo.bar1(), 'new_a')
Expand All @@ -212,7 +215,7 @@ def ban(self):
with self.assertRaises(AttributeError):
foo.bar = 1
with self.assertRaises(AttributeError):
foo.bar2()
foo.bar2().x

foo.bar2.return_value = 'bar2'
self.assertEqual(foo.bar2(), 'bar2')
Expand Down
1 change: 1 addition & 0 deletions Lib/unittest/mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2745,6 +2745,7 @@ def create_autospec(spec, spec_set=False, instance=False, _parent=None,
_new_parent=parent,
**kwargs)
mock._mock_children[entry] = new
new.return_value = child_klass()
_check_signature(original, new, skipfirst=skipfirst)

# so functions created with _set_signature become instance attributes,
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2022-05-03-11-32-29.gh-issue-91803.pI4Juv.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix an error when using a method of objects mocked with
:func:`unittest.mock.create_autospec` after it was sealed with
:func:`unittest.mock.seal` function.