Skip to content

gh-90172: add test for functools.singledispatch on Union types with None type - #92174

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
pr-watson:testsingledispatch
May 3, 2022
Merged

JelleZijlstra merged 4 commits into
python:mainfrom
pr-watson:testsingledispatch

Conversation

@pr-watson

Copy link
Copy Markdown
Contributor

Signed-off-by: prwatson prwatson@redhat.com

gh-90172 added test for functools.singledispatch on Union types with None type

functools.singledispatch needed a test to see if Union types can accept None type as an argument. Tests were added for types.UnionType and typing.Union.

Signed-off-by: prwatson <prwatson@redhat.com>
@pr-watson
pr-watson requested a review from rhettinger as a code owner May 2, 2022 18:29
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 2, 2022
@AlexWaygood
AlexWaygood requested a review from JelleZijlstra May 2, 2022 20:49
Comment thread Lib/test/test_functools.py Resolved
@JelleZijlstra JelleZijlstra changed the title added test for functools.singledispatch on Union types with None type gh-90172: add test for functools.singledispatch on Union types with None type May 2, 2022
@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
@rhettinger
rhettinger removed their request for review May 3, 2022 06:00
Comment thread Lib/test/test_functools.py Resolved
Comment thread Lib/test/test_functools.py Resolved
Comment thread Lib/test/test_functools.py Resolved
Comment thread Lib/test/test_functools.py Resolved
@JelleZijlstra
JelleZijlstra merged commit f03d3dd into python:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants