Skip to content

gh-91760: More strict rules for numerical group references and group names in RE #91792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 10 commits into from
May 8, 2022
Merged

gh-91760: More strict rules for numerical group references and group names in RE #91792

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8909d14
gh-91760: More strict rules for numerical group references and group …
serhiy-storchaka Apr 19, 2022
46f320d
Merge branch 'main' into re-group-name
serhiy-storchaka Apr 23, 2022
6c1a446
Merge branch 'main' into re-group-name
serhiy-storchaka Apr 24, 2022
5026649
Address review comments and minimize the diff.
serhiy-storchaka Apr 24, 2022
2f486af
Merge branch 'main' into re-group-name
serhiy-storchaka Apr 25, 2022
ed09039
Merge branch 'main' into re-group-name
serhiy-storchaka Apr 30, 2022
954ef45
Merge branch 're-group-name' of github.com:serhiy-storchaka/cpython i…
serhiy-storchaka Apr 30, 2022
3835c24
Merge branch 'main' into re-group-name
serhiy-storchaka May 8, 2022
e0d2f85
Merge branch 'main' into re-group-name
serhiy-storchaka May 8, 2022
3c0dfcc
Update What's New
serhiy-storchaka May 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into re-group-name
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Apr 23, 2022
commit 46f320db66f5a56224c74c8085e90091afcb268a
4 changes: 4 additions & 0 deletions Lib/re/_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,10 @@ def _parse(source, state, verbose, nested, first=False):
if condgroup >= MAXGROUPS:
msg = "invalid group reference %d" % condgroup
raise source.error(msg, len(condname) + 1)
if condgroup not in state.grouprefpos:
state.grouprefpos[condgroup] = (
source.tell() - len(condname) - 1
)
else:
source.checkgroupname(condname, 1)
condgroup = state.groupdict.get(condname)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.