GH-88116: Document that PyCodeNew is dangerous, and make PyCode_NewEmpty less dangerous.#91790
Merged
markshannon merged 4 commits intopython:mainfrom Apr 21, 2022
Conversation
vstinner
approved these changes
Apr 21, 2022
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
The overall change LGTM and having an empty object which doesn't crash sounds like a good idea :-) I didn't check PyCode_New() and PyCode_NewWithPosOnlyArgs() arguments.
Member
|
Thanks, nice enhancement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR documents that
PyCodeNewandPyCode_NewWithPosOnlyArgsare risky and shouldn't be used.I've also fixed
PyCode_NewEmptyso that it isn't needlessly dangerous.#88116