Skip to content

gh-89159: Add missing TarInfo members#91564

Merged
AA-Turner merged 2 commits into
python:mainfrom
slateny:s/tarinfo
Jan 12, 2024
Merged

gh-89159: Add missing TarInfo members#91564
AA-Turner merged 2 commits into
python:mainfrom
slateny:s/tarinfo

Conversation

@slateny

@slateny slateny commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

#89159

Copied comments from tarfile.py as I'm not too familiar with exactly what the members do, just so at least it's documented on the tarfile docs page

@slateny
slateny requested a review from ethanfurman as a code owner April 15, 2022 07:32
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Apr 15, 2022
@slateny

slateny commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

@rhettinger Could you take a peek at this? Noticed that you authored #12555 and this just clones them over.

@AA-Turner AA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 12, 2024
@AA-Turner
AA-Turner enabled auto-merge (squash) January 12, 2024 23:13
@AA-Turner
AA-Turner merged commit 3aa4b83 into python:main Jan 12, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @slateny for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2024
(cherry picked from commit 3aa4b83)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jan 12, 2024

Copy link
Copy Markdown

GH-114006 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2024
(cherry picked from commit 3aa4b83)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 12, 2024
@bedevere-app

bedevere-app Bot commented Jan 12, 2024

Copy link
Copy Markdown

GH-114007 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 12, 2024
AA-Turner pushed a commit that referenced this pull request Jan 12, 2024
gh-89159: Document missing TarInfo members (GH-91564)
(cherry picked from commit 3aa4b83)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
AA-Turner pushed a commit that referenced this pull request Jan 12, 2024
gh-89159: Document missing TarInfo members (GH-91564)
(cherry picked from commit 3aa4b83)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@encukou

encukou commented Jan 15, 2024

Copy link
Copy Markdown
Member

This is missing the :type: notes that all other members now have. If you want to be thorough, you cold add them in another PR.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@slateny
slateny deleted the s/tarinfo branch January 24, 2024 07:42
@slateny

slateny commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Opened #114520 as a follow up for types.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants