Merged
Conversation
hugovk
reviewed
Apr 12, 2022
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
approved these changes
Apr 12, 2022
warsaw
requested changes
Apr 12, 2022
|
When you're done making the requested changes, leave the comment: |
Single quotes for consistency.
…o deprecate-imghdr
Member
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @warsaw: please review the changes made to this pull request. |
Remove unnecessary `warnings` import.
warsaw
approved these changes
Apr 13, 2022
Member
warsaw
left a comment
warsaw
left a comment
There was a problem hiding this comment.
LGTM. I'd like to do a cleaning pass through the inlined code, but I'll do that in a follow up PR.
|
@warsaw: Please replace |
ngnpope
reviewed
Apr 14, 2022
warsaw
added a commit
to warsaw/cpython
that referenced
this pull request
Apr 14, 2022
warsaw
added a commit
that referenced
this pull request
Apr 15, 2022
* Rewrite imghdr inlining for clarity and completeness * Move MIMEImage class back closer to the top of the file since it's the important thing. * Use a decorate to mark a given rule function and simplify the rule function names for clarity. * Copy over all the imghdr test data files into the email package's test data directory. This way when imghdr is actually removed, it won't affect the MIMEImage guessing tests. * Rewrite and extend the MIMEImage tests to test for all supported auto-detected MIME image subtypes. * Remove the now redundant PyBanner048.gif data file. * See #91461 (comment) Co-authored-by: Oleg Iarygin <dralife@yandex.ru> Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: GH:warsaw