Skip to content

bpo-34579: Modify test_embed DEFAULT_CONFIG for AIX #9063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 7 commits into from
Sep 15, 2018
Merged

bpo-34579: Modify test_embed DEFAULT_CONFIG for AIX #9063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70f0c39
Modify DEFAULT_CONFIG for AIX
aixtools Sep 4, 2018
1fb1c88
bedevere/news did not like old name
aixtools Sep 4, 2018
e1596ed
Modify NEWS entry
aixtools Sep 9, 2018
d1e6659
Modified per peer review
aixtools Sep 13, 2018
c79fc7c
Define and use NULL_STR constant to account for AIX libc behavior
aixtools Sep 14, 2018
d97b6f0
Modify per peer review
aixtools Sep 15, 2018
45ce7ec
Modify NEWS
aixtools Sep 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Lib/test/test_embed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,15 @@

from collections import namedtuple
import os
import platform
import re
import subprocess
import sys


# AIX libc prints an empty string as '' rather than the string '(null)'
NULL_STR = '' if platform.system() == 'AIX' else '(null)'

class EmbeddingTestsMixin:
def setUp(self):
here = os.path.abspath(__file__)
Expand Down Expand Up @@ -256,7 +260,7 @@ class InitConfigTests(EmbeddingTestsMixin, unittest.TestCase):
'use_environment': 1,
'use_hash_seed': 0,
'hash_seed': 0,
'allocator': '(null)',
'allocator': NULL_STR,
'dev_mode': 0,
'faulthandler': 0,
'tracemalloc': 0,
Expand All @@ -270,11 +274,11 @@ class InitConfigTests(EmbeddingTestsMixin, unittest.TestCase):
'coerce_c_locale': 0,
'coerce_c_locale_warn': 0,

'pycache_prefix': '(null)',
'pycache_prefix': NULL_STR,
'program_name': './_testembed',
'argc': 0,
'argv': '[]',
'program': '(null)',
'program': NULL_STR,

'isolated': 0,
'site_import': 1,
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2018-09-04-15-16-42.bpo-34579.bp4HdM.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix test_embed for AIX
Patch by Michael Felt