Skip to content

bpo-34565: Validate major version in launcher - #9037

Merged
zooba merged 3 commits into
python:masterfrom
bgerrity:major-validation
Sep 4, 2018
Merged

bpo-34565: Validate major version in launcher#9037
zooba merged 3 commits into
python:masterfrom
bgerrity:major-validation

Conversation

@bgerrity

@bgerrity bgerrity commented Sep 2, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

A valid major version was previously any digit sequence. This change restricts the major to either 2 or 3 to match the launcher help text.

https://bugs.python.org/issue34565

@bgerrity
bpo-34565: Validate major version in launcher
ee9fbf4 
A valid major version was previously any digit sequence. This change restricts the major to either 2 or 3 to match the launcher help text.
@bgerrity
bgerrity requested a review from a team as a code owner September 2, 2018 21:54
@zooba zooba added the skip news label Sep 3, 2018
@zooba

zooba commented Sep 3, 2018

Copy link
Copy Markdown
Member

We don't need NEWS entries for just comment changes, since there's no impact on end users that they may need the listing for.

Normally we wouldn't insist on a bug number either, but since it's already there and there's some history around it, it can stay.

@zooba

zooba commented Sep 3, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

If someone else merges this, change the commit message to:

[bpo-34565](https://www.bugs.python.org/issue34565): Change a PC/launcher.c comment to accurately describe valid major versions. (GH-9037)

@zooba
zooba merged commit 3876af4 into python:master Sep 4, 2018
@miss-islington

miss-islington commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Thanks @bgerrity for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2018
@bgerrity @miss-islington
bpo-34565: Change a PC/launcher.c comment to accurately describe vali…
4d89f89 
…d major versions. (pythonGH-9037)

(cherry picked from commit 3876af4)

Co-authored-by: Brendan Gerrity <brerrity@gmail.com>
@miss-islington

miss-islington commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Sorry, @bgerrity and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3876af4f7c2ef87db6d2d83efc229955968926dd 3.6

@bedevere-bot

bedevere-bot commented Sep 4, 2018

Copy link
Copy Markdown

GH-9065 is a backport of this pull request to the 3.7 branch.

@zooba

zooba commented Sep 4, 2018

Copy link
Copy Markdown
Member

We don't really need the 3.6 backport...

@bgerrity
bgerrity deleted the major-validation branch September 4, 2018 17:19
ned-deily pushed a commit that referenced this pull request Oct 6, 2018
@miss-islington @bgerrity @ned-deily
bpo-34565: Change a PC/launcher.c comment to accurately describe vali…
28dd737 
…d major versions. (GH-9037) (GH-9065)

(cherry picked from commit 3876af4)

Co-authored-by: Brendan Gerrity <brerrity@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zooba zooba

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bgerrity @zooba @miss-islington @bedevere-bot @the-knights-who-say-ni