bpo-34443: return __qualname__ in enum __repr__#8989
Closed
danishprakash wants to merge 3 commits into
Closed
Conversation
danishprakash
force-pushed
the
fix-issue-34443
branch
2 times, most recently
from
August 31, 2018 02:08
6fea0ce to
c1b0146
Compare
ethanfurman
reviewed
Sep 11, 2018
ethanfurman
left a comment
ethanfurman
left a comment
Member
There was a problem hiding this comment.
Making some modifications to how module and qualname are stored (will have have those commits in shortly, I hope). After those land, just need to update all the test_enum repr() tests.
repr of a class should return __qualname__ and not __name__ especially in nested classes
Contributor
Author
|
@ethanfurman is there another PR in parallel to this? Anyway, waiting on it. |
ethanfurman
force-pushed
the
fix-issue-34443
branch
from
September 11, 2018 16:09
c1b0146 to
da2f409
Compare
Contributor
|
@danishprakash @ethanfurman I'm triaging open PRs. It looks like the next steps here are:
|
Member
|
Thanks for the bump, @willingc. I have actually decided not to make this change. @danishprakash, thank you for your efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP] repr of a class should return qualname and
not name especially in nested classes
https://bugs.python.org/issue34443