Skip to content

bpo-33187: Fix document ElementInclude (XInclude) support in ElementTree issue - #8861

Merged
scoder merged 10 commits into
python:masterfrom
bansalanjali2512:fix-issue-33187
Sep 11, 2019
Merged

bpo-33187: Fix document ElementInclude (XInclude) support in ElementTree issue#8861
scoder merged 10 commits into
python:masterfrom
bansalanjali2512:fix-issue-33187

Conversation

@bansalanjali2512

@bansalanjali2512 bansalanjali2512 commented Aug 22, 2018

Copy link
Copy Markdown
Contributor

@scoder scoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some comments.

Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
Comment thread Doc/library/xml.etree.elementtree.rst Outdated
@scoder

scoder commented Aug 23, 2018

Copy link
Copy Markdown
Contributor

Please also fix the travis errors. There seems to be trailing whitespace in the file.

@scoder

scoder commented Apr 14, 2019

Copy link
Copy Markdown
Contributor

Any update on this? It would be nice to get this ready to be merged.

@tirkarthi

Copy link
Copy Markdown
Member

There are some trailing spaces in the PR. Please try running make patchcheck locally that will fix the whitespace related errors.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @bansalanjali2512 for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
…ythonGH-8861)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-15958 is a backport of this pull request to the 3.8 branch.

scoder pushed a commit that referenced this pull request Sep 11, 2019
…H-8861) (GH-15958)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @bansalanjali2512 for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
…ythonGH-8861)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-15972 is a backport of this pull request to the 3.7 branch.

scoder pushed a commit that referenced this pull request Sep 11, 2019
…H-8861) (GH-15972)

(cherry picked from commit 97b817e)

Co-authored-by: Anjali Bansal <anjali.mca17.du@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants