bpo-34424: Handle different policy.linesep lengths correctly. by jenstroeger · Pull Request #8803 · python/cpython

jenstroeger · 2018-08-18T04:56:43Z

https://bugs.python.org/issue34424

the-knights-who-say-ni · 2018-08-18T04:56:45Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

jenstroeger · 2018-08-29T20:16:00Z

I did sign the PSF contributor agreement (CLA), so that label should be ok to be removed. Also, since this is a blocking issue on our system: can somebody please review?

Lib/test/test_email/test_generator.py

Lib/email/_header_value_parser.py

bitdancer

Fix and test look good in general. For unit test completeness it would be nice to add a header_value_parser test for this as well, but I don't think it is that important for this particular issue.

Lib/email/_header_value_parser.py

Lib/test/test_email/test_generator.py

Misc/NEWS.d/next/Library/2018-08-18-14-47-00.bpo-34424.wAlRuS.rst

bedevere-bot · 2018-10-19T00:02:36Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

jenstroeger · 2018-10-24T20:26:39Z

I have made the requested changes; please review again.

Also, as a side note, I’ve been running the proposed change for a while now in a live production environment without further issues.

bedevere-bot · 2018-10-24T20:26:42Z

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

jenstroeger · 2018-12-18T11:56:00Z

@bitdancer, any update on this? We could really need this change in mainstream as this is critical for our production servers. Thanks!

jenstroeger · 2019-02-11T10:38:04Z

@bitdancer, a friendly poke… could this please be merged?

bedevere-bot · 2019-05-14T01:07:41Z

@bitdancer: Please replace # with GH- in the commit message next time. Thanks!

miss-islington · 2019-05-14T01:45:16Z

Thanks @jenstroeger for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

…GH-8803) (cherry picked from commit 45b2f88) Co-authored-by: Jens Troeger <jenstroeger@users.noreply.github.com>

bedevere-bot · 2019-05-14T01:45:28Z

GH-13302 is a backport of this pull request to the 3.7 branch.

csabella · 2019-05-14T01:55:57Z

@jenstroeger Thank you for the contribution! 🎉 🎉
@bitdancer Thank you for the review and merge!

(cherry picked from commit 45b2f88) Co-authored-by: Jens Troeger <jenstroeger@users.noreply.github.com>

Julien00859 · 2019-10-29T10:58:11Z

The problem is also affecting latest python 3.6, could it be possible to backport it there ?

pythongh-144125: email: verify headers are sound in BytesGenerator (cherry picked from commit 052e55e) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Denis Ledoux <dle@odoo.com> Co-authored-by: Denis Ledoux <5822488+beledouxdenis@users.noreply.github.com> Co-authored-by: Petr Viktorin <302922+encukou@users.noreply.github.com> Co-authored-by: Bas Bloemsaat <1586868+basbloemsaat@users.noreply.github.com> The fix for the CVE uncovered a known issue in handling policy.linesep lengths fixed by: bpo-34424: Handle different policy.linesep lengths correctly. (python#8803)

pythongh-144125: email: verify headers are sound in BytesGenerator (cherry picked from commit 8cdf620) Co-authored-by: Seth Michael Larson <seth@python.org> Co-authored-by: Denis Ledoux <dle@odoo.com> Co-authored-by: Denis Ledoux <5822488+beledouxdenis@users.noreply.github.com> Co-authored-by: Petr Viktorin <302922+encukou@users.noreply.github.com> Co-authored-by: Bas Bloemsaat <1586868+basbloemsaat@users.noreply.github.com> The fix for the CVE uncovered a known issue in handling policy.linesep lengths fixed by: bpo-34424: Handle different policy.linesep lengths correctly. (python#8803) (cherry-picked from commit 45b2f88) Co-authored-by: Jens Troeger <jenstroeger@users.noreply.github.com>

Handle different policy.linesep lengths correctly.

ab021a4

jenstroeger requested a review from a team as a code owner August 18, 2018 04:56

the-knights-who-say-ni added the CLA not signed label Aug 18, 2018

bedevere-bot added the awaiting review label Aug 18, 2018

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Aug 29, 2018

Add What’s New entry.

96be754

jenstroeger commented Aug 29, 2018

View reviewed changes

Lib/test/test_email/test_generator.py Outdated Show resolved Hide resolved

jenstroeger commented Aug 29, 2018

View reviewed changes

Lib/email/_header_value_parser.py Outdated Show resolved Hide resolved

bitdancer requested changes Oct 19, 2018

View reviewed changes

Lib/email/_header_value_parser.py Outdated Show resolved Hide resolved

Lib/test/test_email/test_generator.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2018-08-18-14-47-00.bpo-34424.wAlRuS.rst Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting review label Oct 19, 2018

bedevere-bot added the awaiting changes label Oct 19, 2018

Updates as per code-review feedback.

970f040

bedevere-bot added awaiting change review and removed awaiting changes labels Oct 24, 2018

csabella requested review from bitdancer and warsaw May 13, 2019 12:37

bitdancer approved these changes May 14, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 14, 2019

bitdancer merged commit 45b2f88 into python:master May 14, 2019

bedevere-bot removed the awaiting merge label May 14, 2019

csabella added the needs backport to 3.7 label May 14, 2019

bedevere-bot removed the needs backport to 3.7 label May 14, 2019

miss-islington added a commit that referenced this pull request May 14, 2019

bpo-34424: Handle different policy.linesep lengths correctly. (GH-8803)

c0abd0c

(cherry picked from commit 45b2f88) Co-authored-by: Jens Troeger <jenstroeger@users.noreply.github.com>

Uh oh!

Conversation

jenstroeger commented Aug 18, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Aug 18, 2018

Uh oh!

jenstroeger commented Aug 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bitdancer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Oct 19, 2018

Uh oh!

jenstroeger commented Oct 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Oct 24, 2018

Uh oh!

jenstroeger commented Dec 18, 2018

Uh oh!

jenstroeger commented Feb 11, 2019

Uh oh!

bedevere-bot commented May 14, 2019

Uh oh!

miss-islington commented May 14, 2019

Uh oh!

bedevere-bot commented May 14, 2019

Uh oh!

csabella commented May 14, 2019

Uh oh!

Julien00859 commented Oct 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jenstroeger commented Aug 18, 2018 •

edited by bedevere-bot

Loading

jenstroeger commented Aug 29, 2018 •

edited

Loading

jenstroeger commented Oct 24, 2018 •

edited

Loading