Skip to content

bpo-34363: Handle namedtuples fields correctly in asdict() and astuple().#8728

Closed
ericvsmith wants to merge 3 commits into
python:masterfrom
ericvsmith:bpo-34363-asdict-astupe-namedtuple
Closed

bpo-34363: Handle namedtuples fields correctly in asdict() and astuple().#8728
ericvsmith wants to merge 3 commits into
python:masterfrom
ericvsmith:bpo-34363-asdict-astupe-namedtuple

Conversation

@ericvsmith

@ericvsmith ericvsmith commented Aug 10, 2018

Copy link
Copy Markdown
Member

Comment thread Lib/test/test_dataclasses.py Outdated
# Make sure we copied these objects and aren't using the
# originals.
self.assertIsNot(d['nt1'], inst1)
self.assertIsNot(d['nt2'], inst1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Should inst1 be inst2 here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@ericvsmith

Copy link
Copy Markdown
Member Author

Closed in preference to #9151.

@ericvsmith ericvsmith closed this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants