Conversation
| self.mode = mode | ||
| self.pwd = None | ||
| self._comment = b'' | ||
| self.strict_timestamps = strict_timestamps |
There was a problem hiding this comment.
I would prefer to make the attribute private: rename it to _strict_timestamps.
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Please rename the attribute.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
@serhiy-storchaka: would you mind to review this change? You requested it:
https://bugs.python.org/issue34097#msg322954
|
In the lack of answer from @serhiy-storchaka, I decided to merge the change. |
4 participants
It has been requested to move the keyword-only argument strict_timestamps to the constructor of ZipFile, rather than have it in the write method.
This PR moves the argument according to the request.
https://bugs.python.org/issue34097