bpo-34331: Fix incorrectly pluralized abstract class error message.#8670
Conversation
|
@merwok @ericvsmith This looks ready to merge to me. Was this on hold for any reason or can it be merged? Thanks! |
|
While the change looks fine to me, I personally think it's not worth the additional code in order to get the minor improvement. Was anyone actually confused by the message? |
|
It is just a polishing change. It is my understanding that this has been done for other error messages. |
|
I understand the nature of the change. I just think it's not worth doing. I'm not going to stop anyone from committing this, though. |
| Py_DECREF(sorted_methods); | ||
| if (joined == NULL) | ||
| return NULL; | ||
| method_count = PyObject_Length(abstract_methods); |
There was a problem hiding this comment.
I suggest you base method_count on sorted_methods, not abstract_methods, since it's sorted_methods that's used to produce joined. I realize it doesn't make much difference, but I think it's easier to reason about. You'd need to move this line to before where you Py_DECREF(sorted_methods).
|
Thank you for your contribution |
10 participants
https://bugs.python.org/issue34331