bpo-34324: Doc README wrong directory name for venv#8650
Merged
Mariatta merged 1 commit intopython:masterfrom Aug 9, 2018
Merged
bpo-34324: Doc README wrong directory name for venv#8650Mariatta merged 1 commit intopython:masterfrom
Mariatta merged 1 commit intopython:masterfrom
Conversation
In the documentation, the `env` directory is specified when we execute the `make venv` command. But in the code, `make venv` will create the virtualenv inside the `venv` directory (defined by `VENVDIR`)
JulienPalard
approved these changes
Aug 3, 2018
Mariatta
approved these changes
Aug 9, 2018
Contributor
|
Thanks @matrixise for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Member
|
Thanks! |
|
GH-8713 is a backport of this pull request to the 3.7 branch. |
|
GH-8714 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 9, 2018
In the documentation, the `env` directory is specified when we execute the `make venv` command. But in the code, `make venv` will create the virtualenv inside the `venv` directory (defined by `VENVDIR`) (cherry picked from commit 599bfa1) Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 9, 2018
In the documentation, the `env` directory is specified when we execute the `make venv` command. But in the code, `make venv` will create the virtualenv inside the `venv` directory (defined by `VENVDIR`) (cherry picked from commit 599bfa1) Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
miss-islington
added a commit
that referenced
this pull request
Aug 9, 2018
In the documentation, the `env` directory is specified when we execute the `make venv` command. But in the code, `make venv` will create the virtualenv inside the `venv` directory (defined by `VENVDIR`) (cherry picked from commit 599bfa1) Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
miss-islington
added a commit
that referenced
this pull request
Aug 9, 2018
In the documentation, the `env` directory is specified when we execute the `make venv` command. But in the code, `make venv` will create the virtualenv inside the `venv` directory (defined by `VENVDIR`) (cherry picked from commit 599bfa1) Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the documentation, the
envdirectory is specified when we executethe
make venvcommand. But in the code,make venvwill create thevirtualenv inside the
venvdirectory (defined byVENVDIR)https://bugs.python.org/issue34324