Skip to content

bpo-34319: Clarify file handler closure in pathlib.read_text#8645

Merged
terryjreedy merged 1 commit into
python:masterfrom
tirkarthi:bpo34319
Aug 6, 2018
Merged

bpo-34319: Clarify file handler closure in pathlib.read_text#8645
terryjreedy merged 1 commit into
python:masterfrom
tirkarthi:bpo34319

Conversation

@tirkarthi

@tirkarthi tirkarthi commented Aug 3, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Made the suggested changes in pathlib.read_text to clarify file handler being closed. Feel free to suggest if the wording can be improved.

Ref : https://bugs.python.org/issue34319#msg322991

How about if we add "The file is opened and then closed." before "The optional parameters have the same meaning as in open()."

Since this is a doc change I think this doesn't require a NEWS entry.

Thanks

https://bugs.python.org/issue34319

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 3, 2018
@terryjreedy

terryjreedy commented Aug 6, 2018

Copy link
Copy Markdown
Member

The test failures are un-related known problems with test_subprocess on two of the VSTS testers.

Tirkarthi: I was planning to open a PR with my suggestion after discussion.

@terryjreedy
terryjreedy merged commit 5b2657f into python:master Aug 6, 2018
@miss-islington

miss-islington commented Aug 6, 2018

Copy link
Copy Markdown
Contributor

Thanks @tirkarthi for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

bedevere-bot commented Aug 6, 2018

Copy link
Copy Markdown

GH-8694 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

bedevere-bot commented Aug 6, 2018

Copy link
Copy Markdown

GH-8695 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2018
@tirkarthi @miss-islington
bpo-34319: Clarify file handler closure in pathlib.read_text (pythonG…
74dbda1 
…H-8645)

Patch by Terry Jan Reedy.
(cherry picked from commit 5b2657f)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2018
@tirkarthi @miss-islington
bpo-34319: Clarify file handler closure in pathlib.read_text (pythonG…
d909716 
…H-8645)

Patch by Terry Jan Reedy.
(cherry picked from commit 5b2657f)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 6, 2018
@miss-islington @tirkarthi
bpo-34319: Clarify file handler closure in pathlib.read_text (GH-8645)
1c6df83 
Patch by Terry Jan Reedy.
(cherry picked from commit 5b2657f)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 6, 2018
@miss-islington @tirkarthi
bpo-34319: Clarify file handler closure in pathlib.read_text (GH-8645)
3da5c5c 
Patch by Terry Jan Reedy.
(cherry picked from commit 5b2657f)

Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
@tirkarthi

tirkarthi commented Aug 7, 2018

Copy link
Copy Markdown
Member Author

@terryjreedy Thanks for merging this. Sorry, I thought your suggestion was good but no PR was raised. So I thought to raise an initial PR here and then change the wording as needed from reviewers.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok approved these changes
@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tirkarthi @terryjreedy @miss-islington @bedevere-bot @merwok @CuriousLearner @the-knights-who-say-ni