-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
bpo-34249: Full set of format codes applies to strftime only #8502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The existing paragraph about the full set of format code implies that it applies for strftime only, as it mentiones refers to C library’s strftime(). This is an effort to clarify that the full set of format codes does not apply to both strftime and strptime
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again for your contribution, we look forward to reviewing it! |
|
I am not sure if this change requires an entry in Misc/NEWS.d/next/ or it can simply get a "skip news" label. |
|
@vkatsikaros I agree that this does not necessarily need a news entry. I am fairly certain that it is true that the supported codes varies depending on the platform for both I see two ways to do this:
Not sure which is better, nor am I confident I like the wording of option 2. |
|
I concur with @pganssle, can you take a look at it @vkatsikaros ? |
|
@vkatsikaros, please resolve the merge conflict and address the code review. Thank you! |
|
OP has not been active on this PR thread for nearly four years, but core devs have requested changes and there is now a merge conflict. I'm therefore closing this PR. @vkatsikaros, if you'd still like to work on this issue, feel free to open a new PR. Alternatively, ping me, and I'll happily reopen the PR. Thanks! 🙂 |
The existing paragraph about the full set of format code implies that it applies for strftime only, as it mentiones refers to C library’s strftime(). This is an effort to clarify that the full set of format codes does not apply to both strftime and strptime
https://bugs.python.org/issue34249