Skip to content

bpo-34245: install Python libraries with more standard 0755 mode#8492

Merged
ned-deily merged 1 commit into
python:masterfrom
jdemeyer:bpo34245
Dec 9, 2018
Merged

bpo-34245: install Python libraries with more standard 0755 mode#8492
ned-deily merged 1 commit into
python:masterfrom
jdemeyer:bpo34245

Conversation

@jdemeyer

@jdemeyer jdemeyer commented Jul 27, 2018

Copy link
Copy Markdown
Contributor

@@ -0,0 +1,2 @@
The Python library is now installed with write permission (mode 0755), which
is the standard way of installing libraries.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"library" is unclear word. "py?" files are "Python library" too.
I think "shared module" or "DLL" are bettor wording.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Shared library" is probably the correct term. This change does not apply to the Windows DLLs or pyds, and using that term here may be confusing.

@jdemeyer

Copy link
Copy Markdown
Contributor Author

Changed wording to "shared library"

@ned-deily

Copy link
Copy Markdown
Member

I think the change is fine for master (3.8). As far as backporting, it is hard to make a case that the existing behavior is a bug since the choice of permissions was deliberate. Since the current behavior has been around for many years with little or no prior complaints, I don't think we should risk breaking anything by changing how the existing maintenance branches behave.

@jdemeyer
jdemeyer deleted the bpo34245 branch March 26, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants