Skip to content

[2.7] bpo-33336: Legalize MOVE command (GH-6569)#8370

Closed
mcepl wants to merge 3 commits intopython:2.7from
mcepl:33336_legalize_move_command_py27
Closed

[2.7] bpo-33336: Legalize MOVE command (GH-6569)#8370
mcepl wants to merge 3 commits intopython:2.7from
mcepl:33336_legalize_move_command_py27

Conversation

@mcepl
Copy link
Copy Markdown
Contributor

@mcepl mcepl commented Jul 21, 2018 •
edited by bedevere-bot
Loading

When running

    box = IMAP4_SSL(host)
    box.login(user, passw)
    msgs = somehowget_uids_of_messsages_to_move()
    box.uid('MOVE', msgs, 'target')

I get an error "Unknown IMAP4 UID command: MOVE". The problem is that imaplib contains a list Commands of the permitted IMAP commands, and MOVE is not included, even though it is perfectly legal (and quite widely supported) command according to RFC-6851.

@vstinner , @warsaw

https://bugs.python.org/issue33336

@mcepl mcepl requested a review from a team July 21, 2018 08:20
@mcepl mcepl requested a review from a team as a code owner July 21, 2018 08:20
@bedevere-bot bedevere-bot mentioned this pull request Jul 21, 2018
Merged
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jul 21, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@mcepl mcepl changed the base branch from master to 2.7 July 21, 2018 08:22
@mcepl
Copy link
Copy Markdown
Contributor Author

mcepl commented Jul 21, 2018

This is wrong, I have already signed CLA (see the master PR).

@terryjreedy terryjreedy removed their request for review July 21, 2018 17:52
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jul 23, 2018

I close this PR. I prefer to use miss-inlgton bot to generate backports PR to get "(cherry picked from commit XXX)" in the commit message.

@vstinner vstinner closed this Jul 23, 2018
@mcepl mcepl deleted the 33336_legalize_move_command_py27 branch July 23, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@gpshead gpshead Awaiting requested review from gpshead

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@rhettinger rhettinger Awaiting requested review from rhettinger

@skrah skrah Awaiting requested review from skrah

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcepl @the-knights-who-say-ni @vstinner @terryjreedy @bedevere-bot