AppVeyor: build Python in 64-bit mode#8363
Conversation
Previously, Python was built in 32-bit mode and so issues specific to 64-bit mode like compiler warnings could be missed.
|
Example of a recent warning missed by AppVeyor: #8359 |
|
Couldn't issues specific to 32-bit mode be missed? |
|
We have 32 and 64 bit Windows buildbots. I expect that Python has more 64
bit users on Windows. I recall more issues on 64 bit Windows, compiler
warnings are the most common.
|
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I'm not a Windows expert, but these changes LGTM.
|
My goal for AppVeyor is just speed (that's why it builds in FTR, VSTS already does both 32- and 64-bit builds, and it appears from those logs that 64-bit is generally about 2 minutes slower than 32-bit. |
I looked at AppVeyor tests timing:
So there is no significant difference. -- I looked at the "VSTS: Windows" logs on this PR: I confirm that the 64 bits build is 2 min slower than the 32 bits build. No idea why. But this PR only changes AppVeyor configuration. |
|
I switched AppVeyor to 64-bit on the master branch. My use case is to catch compiler warnings, and usually I only fix compiler warnings in the master branch. So I'm not sure about backporting this change to 2.7, 3.6 and 3.7 branches. What do you think? |
Previously, Python was built in 32-bit mode and so issues specific to
64-bit mode like compiler warnings could be missed.