Skip to content

bpo-34011: Update code copying DLLs and init.tcl into venvs. #8253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 4 commits into from
Jul 20, 2018
Merged

bpo-34011: Update code copying DLLs and init.tcl into venvs. #8253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c87f932
bpo-34011: Remove code copying DLLs and init.tcl into venvs.
vsajip Jul 11, 2018
3f3b086
Added a NEWS entry.
vsajip Jul 11, 2018
d86e914
Make copying conditional on source build.
vsajip Jul 12, 2018
c4a2ef7
Updated NEWS entry.
vsajip Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/venv/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import shutil
import subprocess
import sys
import sysconfig
import types

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -207,7 +208,10 @@ def setup_python(self, context):
copier(context.env_exe, path, relative_symlinks_ok=True)
if not os.path.islink(path):
os.chmod(path, 0o755)
else:
elif sysconfig.is_python_build(True):
# See bpo-34011. This copying code should only be needed when a
# venv is created from a source Python build (i.e. not an installed
# Python)
subdir = 'DLLs'
include = self.include_binary
files = [f for f in os.listdir(dirname) if include(f)]
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Windows/2018-07-11-15-58-06.bpo-34011.Ho_d5T.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
A suite of code has been changed which copied across DLLs and init.tcl from
the running Python location into a venv being created. These copies are needed
only when running from a Python source build, and the copying code is now only
run when that is the case, rather than whenever a venv is created.