WIP: use assign expr on if#8116
Closed
vstinner wants to merge 2 commits into
Closed
Conversation
Replace:
var = expr
if var:
...
with:
if (var := expr):
...
Don't replace when:
* var is used after the if
* Code like "var = regex.match(); if var: return var.group(1)"
is left unchanged since it's covered by a dedicated PR.
Sometimes, var is only used in the condition and so has been removed
in this change. Maybe such kind of pattern should be addressed in a
different pull request.
This patch is restricted to the simplest test "if var:", other
conditions like "if var > 0:" are left unchaned to keep this change
reviewable (short enough).
vstinner
requested review from
a team,
1st1,
asvetlov,
ericvsmith,
rhettinger and
skrah
as code owners
Member
Author
|
The PEP 572 has been accepted. I only wrote these WIP PEPs to help me to discuss the PEP. I never intended to propose these changes to be merged. So I close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace:
with:
Don't replace when:
var = regex.match(); if var: return var.group(1)is left unchanged since it's covered by a dedicated PR.
Sometimes, var is only used in the condition and so has been removed
in this change. Maybe such kind of pattern should be addressed in a
different pull request.
This patch is restricted to the simplest test
if var:, otherconditions like
if var > 0:are left unchaned to keep this changereviewable (short enough).