Skip to content

[3.7] bpo-32942: Fix environment dependent test_script_helper (GH-8034)#8087

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-a390cb6-3.7
Jul 4, 2018
Merged

[3.7] bpo-32942: Fix environment dependent test_script_helper (GH-8034)#8087
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-a390cb6-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 4, 2018

Copy link
Copy Markdown
Contributor

Result of function interpreter_requires_environment() depends on os.environ.
This was not covered by the tests, leading to fail when PYTHONHOME was set.
(cherry picked from commit a390cb6)

Co-authored-by: Lorenz Mende Lorenz.mende@gmail.com

https://bugs.python.org/issue32942

Result of function interpreter_requires_environment() depends on os.environ.
This was not covered by the tests, leading to fail when PYTHONHOME was set.
(cherry picked from commit a390cb6)

Co-authored-by: Lorenz Mende <Lorenz.mende@gmail.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot 🤖!

@miss-islington

Copy link
Copy Markdown
Contributor Author

@LorenzMende and @vstinner: Backport status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 6b3ff35 into python:3.7 Jul 4, 2018
@miss-islington
miss-islington deleted the backport-a390cb6-3.7 branch July 4, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants