bpo-25007: Add copy protocol support to zlib compressors and decompressors#7940
Merged
serhiy-storchaka merged 2 commits intopython:masterfrom Jun 27, 2018
Merged
Conversation
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. Just two style nits.
Doc/library/zlib.rst
Outdated
|
|
||
|
|
||
| .. versionchanged:: 3.8 | ||
| Added :func:`copy.copy` and :func:`copy.deepcopy` support to Compression |
Member
There was a problem hiding this comment.
Use lower case for compression objects.
Doc/library/zlib.rst
Outdated
|
|
||
|
|
||
| .. versionchanged:: 3.8 | ||
| Added :func:`copy.copy` and :func:`copy.deepcopy` support to Decompression |
serhiy-storchaka
approved these changes
Jun 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created from scratch; the patch submitted on the bug tracker two years ago needed to be rewritten, and it lacked
deepcopy()support, documentation, and tests.https://bugs.python.org/issue25007