Skip to content

bpo-33895: Relase GIL while calling functions that acquire Windows loader lock#7789

Merged
zooba merged 1 commit intopython:masterfrom
tonyroberts:fix-issue-33895
Feb 2, 2019
Merged

bpo-33895: Relase GIL while calling functions that acquire Windows loader lock#7789
zooba merged 1 commit intopython:masterfrom
tonyroberts:fix-issue-33895

Conversation

@tonyroberts
Copy link
Copy Markdown
Contributor

@tonyroberts tonyroberts commented Jun 19, 2018

Windows functions LoadLibrary, GetProcAddress, FreeLibrary and GetModuleHandle use the system loader lock. Calling these while holding the GIL will cause a dead lock in the rare occasion that another thread
is detaching and needs to destroy its thread state at the same time.

https://bugs.python.org/issue33895

@tonyroberts tonyroberts requested a review from a team as a code owner June 19, 2018 10:55
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

…ader lock

Windows functions LoadLibrary, GetProcAddress, FreeLibrary and
GetModuleHandle use the system loader lock. Calling these while holding
the GIL will cause a dead lock in the rare occasion that another thread
is detaching and needs to destroy its thread state at the same time.
@tonyroberts
Copy link
Copy Markdown
Contributor Author

CLA has been signed, but only this morning so probably not processed yet.

@zooba
Copy link
Copy Markdown
Member

zooba commented Feb 2, 2019

Retriggering the CI systems, as I believe this is ready to merge.

@zooba zooba merged commit 4860f01 into python:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants