Fix description inconsistent with its implementation#776
Merged
Conversation
Fix wrong description about SimpleXMLRPCServer class constructor parameter `bind_and_activate`. Passing True as the `bind_and_activate` *do* immediately opening and binding to thier socket. + `SimpleXMLRPCServer constructor <https://github.com/python/cpython/blob/2.6/Lib/SimpleXMLRPCServer.py#L542>`_ + `TCPServer constructor called from SimpleXMLRPCServer constructor <https://github.com/python/cpython/blob/2.6/Lib/SocketServer.py#L401>`_
serhiy-storchaka
approved these changes
Mar 26, 2018
serhiy-storchaka
added
needs backport to 3.6
docs
Contributor
|
Thanks @cocoatomo for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 26, 2018
…nd_activate. (pythonGH-776) Passing True as the `bind_and_activate` *do* immediately opening and binding to their socket. (cherry picked from commit e622357) Co-authored-by: cocoatomo <cocoatomo77@gmail.com>
|
GH-6254 is a backport of this pull request to the 3.7 branch. |
|
GH-6255 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 26, 2018
…nd_activate. (pythonGH-776) Passing True as the `bind_and_activate` *do* immediately opening and binding to their socket. (cherry picked from commit e622357) Co-authored-by: cocoatomo <cocoatomo77@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 26, 2018
…nd_activate. (pythonGH-776) Passing True as the `bind_and_activate` *do* immediately opening and binding to their socket. (cherry picked from commit e622357) Co-authored-by: cocoatomo <cocoatomo77@gmail.com>
|
GH-6256 is a backport of this pull request to the 3.6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wrong description about SimpleXMLRPCServer class constructor parameter
bind_and_activate.Passing True as the
bind_and_activatedo immediately opening and binding to thier socket.