bpo-33660: Fix PosixPath to resolve a relative path on root#7666
Closed
corona10 wants to merge 1 commit into
Closed
bpo-33660: Fix PosixPath to resolve a relative path on root#7666corona10 wants to merge 1 commit into
corona10 wants to merge 1 commit into
Conversation
corona10
changed the title
corona10
changed the title
Member
Author
|
@pitrou Please take a look :) There are 2 options to fix this bug. if path == sep:
newpath = sep + name
else:
newpath = path + sep + name or if path == '/':
newpath = sep + name
else:
newpath = path + sep + name I choose the first one. |
Member
Author
|
Can I get a review from anyone who related with this module? |
Contributor
|
@corona10 Can you clarify why this was closed? Perhaps in the issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33660
Needs backport to 3.7 3.6