bpo-33708: Fix method reference links in asyncio.Event and asyncio.Condition docs - #7280
Closed
timofurrer wants to merge 3 commits into
Closed
bpo-33708: Fix method reference links in asyncio.Event and asyncio.Condition docs#7280timofurrer wants to merge 3 commits into
timofurrer wants to merge 3 commits into
Conversation
timofurrer
changed the title
It makes sense to use these for all class methods here. This makes the use consistent in this file, avoiding potential future problems.
taleinat
approved these changes
Jun 12, 2018
taleinat
left a comment
taleinat
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but this should likely have another set of eyes review it.
Member
|
The asyncio documentation has been rewritten after this change has been written. It seems like the missing references issue is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses the linking problem reported in Issue #33708.
https://bugs.python.org/issue33708