Skip to content

bpo-33524: Fix the behavior when max_line_length is 0 or None in email.policy#6966

Closed
Licht-T wants to merge 2 commits intopython:masterfrom
Licht-T:fix-zero-max_line_length-bahavior-in-email-policy
Closed

bpo-33524: Fix the behavior when max_line_length is 0 or None in email.policy#6966
Licht-T wants to merge 2 commits intopython:masterfrom
Licht-T:fix-zero-max_line_length-bahavior-in-email-policy

Conversation

@Licht-T
Copy link
Copy Markdown
Contributor

@Licht-T Licht-T commented May 18, 2018 •
edited by bedevere-bot
Loading

@Licht-T Licht-T requested a review from a team as a code owner May 18, 2018 12:03
@Licht-T
Copy link
Copy Markdown
Contributor Author

Licht-T commented May 18, 2018

CI in Windows failed by non-related tests, eg. test.test_asyncio.test_base_events.BaseLoopSockSendfileTests.

bitdancer
bitdancer requested changes Jul 25, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@bitdancer bitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a news item, otherwise it looks good.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 25, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@DrLuke
Copy link
Copy Markdown

DrLuke commented Feb 13, 2019

Please add the news entry, I am desperately awaiting this fix!

@maxking
Copy link
Copy Markdown
Contributor

maxking commented May 17, 2019

Ping @Licht-T!

If this PR is abandoned, I can re-submit the patch with the news item (and attribution to original author ofc).

@DrLuke
Copy link
Copy Markdown

DrLuke commented May 17, 2019

@maxking I think it can be considered abandoned, it's been over a year. Thank you!

@maxking maxking mentioned this pull request May 17, 2019
Merged
@csabella csabella closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Licht-T @bedevere-bot @DrLuke @maxking @bitdancer @the-knights-who-say-ni @csabella