Skip to content

bpo-23722: Raise RuntimeError for absent __classcell__.#6931

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:classcell-runtime-error
May 20, 2018
Merged

bpo-23722: Raise RuntimeError for absent __classcell__.#6931
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:classcell-runtime-error

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 17, 2018

Copy link
Copy Markdown
Member

A DeprecationWarning was emitted in Python 3.6-3.7.

https://bugs.python.org/issue23722

A DeprecationWarning was emitted in Python 3.6-3.7.
@serhiy-storchaka
serhiy-storchaka force-pushed the classcell-runtime-error branch from e661d7d to cf194a1 Compare May 17, 2018 10:36

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncoghlan

Copy link
Copy Markdown
Contributor

The Appveyor failure doesn't look related, so I restarted it.

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

So it should be RuntimeError, not RuntimeWarning (#6933)?

@ncoghlan

Copy link
Copy Markdown
Contributor

Yeah, RuntimeError is correct - I completely missed that I'd mistakenly mentioned RuntimeWarning instead in the docs (I added a comment to the BPO issue about that as well)

@serhiy-storchaka
serhiy-storchaka merged commit f5e7b19 into python:master May 20, 2018
@serhiy-storchaka
serhiy-storchaka deleted the classcell-runtime-error branch May 20, 2018 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants