Skip to content

bpo-33488: Satisfy markdownlint for pull request#6786

Merged
benjaminp merged 1 commit into
python:masterfrom
grimreaper:eax/mdl/mdl_fix_template_fix
May 14, 2018
Merged

bpo-33488: Satisfy markdownlint for pull request#6786
benjaminp merged 1 commit into
python:masterfrom
grimreaper:eax/mdl/mdl_fix_template_fix

Conversation

@grimreaper

@grimreaper grimreaper commented May 14, 2018

Copy link
Copy Markdown
Contributor

skip news
markdownlint is, as the name implies, a tool for linting markdown files. The current template has several warnings. Fix them.

https://bugs.python.org/issue33488

./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be
surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should
be surrounded by blank lines
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @grimreaper for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @grimreaper and @benjaminp, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5cd22cf2097a6dd209999cf97858d54564a3be87 3.7

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @grimreaper and @benjaminp, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5cd22cf2097a6dd209999cf97858d54564a3be87 3.6

benjaminp pushed a commit that referenced this pull request May 14, 2018
…H-6786)

./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be
surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should
be surrounded by blank lines.
(cherry picked from commit 5cd22cf)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-6787 is a backport of this pull request to the 3.7 branch.

benjaminp added a commit that referenced this pull request May 14, 2018
…H-6786)

./.github/PULL_REQUEST_TEMPLATE.md:8: MD031 Fenced code blocks should be
surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:10: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:19: MD031 Fenced code blocks should
be surrounded by blank lines
./.github/PULL_REQUEST_TEMPLATE.md:21: MD031 Fenced code blocks should
be surrounded by blank lines.
(cherry picked from commit 5cd22cf)

Co-authored-by: Eitan Adler <grimreaper@users.noreply.github.com>
@grimreaper grimreaper deleted the eax/mdl/mdl_fix_template_fix branch May 15, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants