bpo-33485: make autoconf behave correctly in more cases#6782
Closed
grimreaper wants to merge 2 commits into
Closed
bpo-33485: make autoconf behave correctly in more cases#6782grimreaper wants to merge 2 commits into
grimreaper wants to merge 2 commits into
Conversation
grimreaper
force-pushed
the
eax/build/autoconf_target
branch
from
May 13, 2018 19:06
208a791 to
f3d7973
Compare
grimreaper
force-pushed
the
eax/build/autoconf_target
branch
5 times, most recently
from
May 19, 2018 00:22
3529454 to
b192b1a
Compare
grimreaper
force-pushed
the
eax/build/autoconf_target
branch
2 times, most recently
from
May 25, 2018 14:19
36b2aea to
bde3063
Compare
grimreaper
force-pushed
the
eax/build/autoconf_target
branch
from
June 9, 2018 17:46
bde3063 to
718104b
Compare
grimreaper
force-pushed
the
eax/build/autoconf_target
branch
2 times, most recently
from
June 29, 2018 14:32
17078cb to
960a617
Compare
grimreaper
force-pushed
the
eax/build/autoconf_target
branch
from
July 28, 2018 07:42
960a617 to
92b321c
Compare
MaxwellDupre
approved these changes
May 27, 2022
MaxwellDupre
left a comment
MaxwellDupre
left a comment
Contributor
There was a problem hiding this comment.
I see in the confg.log:
config.status:1311: creating pyconfig.h
config.status:1492: pyconfig.h is unchanged
Not sure if --force flag works here but not doing any harm.
Also test results:
Test suite interrupted by signal SIGINT.
1 test omitted:
test_poplib (obvious bug but unrelated)
400 tests OK.
Noted Debian has switched to autoreconf because of autoconf bugs. Also, this looks more efficient and one level up cant be bad.
However, the NEWS entry could be better - more in line with PR title and/or bug report.
Member
Member
|
The rule now uses autoreconf with force and error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33485