Skip to content

bpo-33484: Link instead of run certain test programs#6781

Closed
grimreaper wants to merge 3 commits into
python:mainfrom
grimreaper:eax/build/run_vs_link
Closed

bpo-33484: Link instead of run certain test programs#6781
grimreaper wants to merge 3 commits into
python:mainfrom
grimreaper:eax/build/run_vs_link

Conversation

@grimreaper

@grimreaper grimreaper commented May 13, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The build system attempts to run certain test code when it can actually
just link the code. This is a minor performance optimization but is really
a semantic correctness issue.

https://bugs.python.org/issue33484

@grimreaper grimreaper changed the title Link instead of run certain test programs bpo-33484: Link instead of run certain test programs May 13, 2018
@grimreaper
grimreaper force-pushed the eax/build/run_vs_link branch 2 times, most recently from 5c07601 to 4b8cf22 Compare May 13, 2018 19:06
@grimreaper grimreaper mentioned this pull request May 13, 2018
Closed
@grimreaper
grimreaper force-pushed the eax/build/run_vs_link branch 5 times, most recently from 0d905d4 to 7eb8b7f Compare May 19, 2018 00:22
@grimreaper
grimreaper force-pushed the eax/build/run_vs_link branch 2 times, most recently from 3670814 to 5d68156 Compare May 25, 2018 14:19
@grimreaper
grimreaper force-pushed the eax/build/run_vs_link branch from 5d68156 to d77ae7d Compare June 9, 2018 17:46
@grimreaper
grimreaper force-pushed the eax/build/run_vs_link branch 2 times, most recently from f3f1f7c to e186337 Compare June 29, 2018 14:32
@grimreaper
Link instead of run certain test programs
ccf4058 
The build system attempts to run certain test code when it can actually
just link the code. This is a minor performance optimization but is
really a semantic correctness issue.
@grimreaper
add news
d935946
@grimreaper
regen
94546d0
@grimreaper
grimreaper force-pushed the eax/build/run_vs_link branch from e186337 to 94546d0 Compare July 28, 2018 07:42
MaxwellDupre
MaxwellDupre approved these changes May 9, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests known for this part, so ran full suite:
1 test omitted:
test_poplib
390 tests OK.
7 tests failed.
Looks ok.

@github-actions

github-actions Bot commented Aug 18, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 18, 2022
iritkatriel
iritkatriel requested changes Nov 26, 2022
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot

bedevere-bot commented Nov 26, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@grimreaper grimreaper mannequin mentioned this pull request Apr 10, 2022
Closed
@encukou

encukou commented Mar 19, 2024

Copy link
Copy Markdown
Member

Closing, see the issue for details.

@encukou encukou closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel requested changes
+1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@grimreaper @bedevere-bot @encukou @iritkatriel @MaxwellDupre @the-knights-who-say-ni @ezio-melotti