[3.7] bpo-33400: Clarified documentation to indicate no strict adherence to ISO 8601. (GH-6702)#6704
Merged
Merged
Conversation
… ISO 8601. (pythonGH-6702) (cherry picked from commit c4994dc) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Contributor
Author
|
@vsajip: Backport status check is done, and it's a success ✅ . |
vadmium
reviewed
May 6, 2018
| :func:`time.strftime` to format the creation time of the | ||
| record. Otherwise, the ISO8601 format is used. The resulting string is | ||
| returned. | ||
| record. Otherwise, an ISO8601-like (or RDC 3339-like) format is used. The |
Member
There was a problem hiding this comment.
Well spotted, thanks! Will correct.
Member
|
You can use the reStructuredText markup: |
pganssle
reviewed
May 15, 2018
| The default format for date/time display (shown above) is ISO8601. If you need | ||
| more control over the formatting of the date/time, provide a *datefmt* | ||
| argument to ``basicConfig``, as in this example:: | ||
| The default format for date/time display (shown above) is like ISO8601 or |
Member
There was a problem hiding this comment.
This is unnecessary. It is not "like" ISO8601, it is ISO 8601.
Member
There was a problem hiding this comment.
For now, I will sync the changes to be in line with the other branches, but won't close the issue. I think it's best just to state what the format is, make a reference to RFC 3339, and leave it at that. I will address this in a further update.
Contributor
Author
|
Thanks, @vsajip! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c4994dc)
Co-authored-by: Vinay Sajip vinay_sajip@yahoo.co.uk
https://bugs.python.org/issue33400