Skip to content

bpo-33352: Skip test if rt.bat does not exist#6654

Merged
vstinner merged 1 commit into
python:masterfrom
andresdelfino:fix-test_pcbuild_rt
Apr 30, 2018
Merged

bpo-33352: Skip test if rt.bat does not exist#6654
vstinner merged 1 commit into
python:masterfrom
andresdelfino:fix-test_pcbuild_rt

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Apr 30, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

vstinner
vstinner approved these changes Apr 30, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
vstinner merged commit c3b7a6d into python:master Apr 30, 2018
@vstinner

vstinner commented Apr 30, 2018

Copy link
Copy Markdown
Member

Thanks. I just added "test_regrest" to the commit message.

@miss-islington

miss-islington commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

bedevere-bot commented Apr 30, 2018

Copy link
Copy Markdown

GH-6656 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2018
@andresdelfino @miss-islington
bpo-33352: Skip test_regrtest test if rt.bat does not exist (pythonGH…
f978c12 
…-6654)

(cherry picked from commit c3b7a6d)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
vstinner pushed a commit that referenced this pull request Apr 30, 2018
@miss-islington @andresdelfino @vstinner
bpo-33352: Skip test_regrtest test if rt.bat does not exist (GH-6654) (…
8075868 
…#6656)

(cherry picked from commit c3b7a6d)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino
andresdelfino deleted the fix-test_pcbuild_rt branch May 1, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andresdelfino @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni