Skip to content

[2.7] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) #6585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 11 commits into from
Oct 20, 2018
Merged

[2.7] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639) #6585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
29e4897
[2.7] bpo-31500: IDLE: Scale default fonts on HiDPI displays. (GH-3639)
serhiy-storchaka Sep 21, 2017
b2197e1
Add fix_scaling to pyshell
csabella Apr 24, 2018
47a6464
Fix for round() to be int
csabella Apr 25, 2018
5e5bc8c
Merge branch '2.7' into backport-a96c96f-2.7
csabella Apr 25, 2018
3b38a20
Merge branch '2.7' into backport-a96c96f-2.7
csabella Apr 27, 2018
c590ccb
Merge branch '2.7' into backport-a96c96f-2.7
serhiy-storchaka Apr 30, 2018
696e04f
Merge branch '2.7' into backport-a96c96f-2.7
csabella May 4, 2018
9806601
Merge branch '2.7' into backport-a96c96f-2.7
csabella May 6, 2018
36b48d6
Merge branch '2.7' into backport-a96c96f-2.7
csabella May 12, 2018
3ff7b47
Merge branch '2.7' into backport-a96c96f-2.7
csabella May 14, 2018
e64ea43
Merge branch '2.7' into backport-a96c96f-2.7
csabella May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/idlelib/FileList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,10 @@ def canonize(self, filename):

def _test():
from idlelib.EditorWindow import fixwordbreaks
from idlelib.run import fix_scaling
import sys
root = Tk()
fix_scaling(root)
fixwordbreaks(root)
root.withdraw()
flist = FileList(root)
Expand Down
2 changes: 2 additions & 0 deletions Lib/idlelib/PyShell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1552,6 +1552,8 @@ def main():
# start editor and/or shell windows:
root = Tk(className="Idle")
root.withdraw()
from idlelib.run import fix_scaling
fix_scaling(root)

# set application icon
icondir = os.path.join(os.path.dirname(__file__), 'Icons')
Expand Down
14 changes: 14 additions & 0 deletions Lib/idlelib/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ def show_socket_error(err, address):
import Tkinter
import tkMessageBox
root = Tkinter.Tk()
fix_scaling(root)
root.withdraw()
if err.args[0] == 61: # connection refused
msg = "IDLE's subprocess can't connect to %s:%d. This may be due "\
Expand Down Expand Up @@ -240,6 +241,19 @@ def exit():
capture_warnings(False)
sys.exit(0)


def fix_scaling(root):
"""Scale fonts on HiDPI displays."""
import tkFont
scaling = float(root.tk.call('tk', 'scaling'))
if scaling > 1.4:
for name in tkFont.names(root):
font = tkFont.Font(root=root, name=name, exists=True)
size = int(font['size'])
if size < 0:
font['size'] = int(round(-0.75*size))


class MyRPCServer(rpc.RPCServer):

def handle_error(self, request, client_address):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2017-09-18-10-43-03.bpo-31500.Y_YDxA.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Default fonts now are scaled on HiDPI displays.