bpo-33336: Legalize MOVE command#6569
bpo-33336: Legalize MOVE command#6569vstinner merged 3 commits intopython:masterfrom mcepl:33336_legalize_move_command
Conversation
|
I would love to eventually have some way how to make moving messages universally possible (https://bugs.python.org/issue33327), but this is the least what I can hope for. |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
You should add a ".. versionchanged:: 3.7" markup near https://docs.python.org/dev/library/imaplib.html#imaplib.IMAP4.uid (Doc/library/imaplib.rst) to document that MOVE is now supported.
@vstinner I still hold that this is not change in API. We never documented which IMAP commands are supported in I would like this bugfix be ported to other older versions of Python, which won't happen for change of API. And yes, if calling this bugfix as change of API makes you stop stalling merging of this PR (I thought we went through all this on IRC, but apparently that discussion didn't change anything), I am willing to shut up and let it be limited to 3.8. Better that than nothing. |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I don't know the IMAP protocol nor the imaplib module. I would be more confortable if someone from the "email team", @warsaw or someone else review this PR. But this PR was created in April, 3 monhs ago, and didn't get any review whereas the PR looks safe and good (to me).
I suggest to backport the change to 2.7, 3.6 and 3.7 branches.
I will merge this PR next week except if someone show up against it.
| @@ -0,0 +1,2 @@ | |||
| ``imaplib`` now allows ``MOVE`` command in ``IMAP4.uid()`` and potentially | |||
| as a name of supported method of ``IMAP4`` object. | |||
There was a problem hiding this comment.
Would you mind to add a reference to the RFC 6851? Example:
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851: IMAP MOVE Extension)
and potentially as a name of supported method of IMAP4 object.
|
@bitdancer, @warsaw: Would you mind to review this imaplib PR? |
|
GH-8370 is a backport of this pull request to the 2.7 branch. |
|
GH-8373 is a backport of this pull request to the 3.6 branch. |
|
GH-8386 is a backport of this pull request to the 3.7 branch. |
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851: IMAP MOVE Extension) and potentially as a name of supported method of IMAP4 object. (cherry picked from commit caa331d) Co-authored-by: Matěj Cepl <mcepl@cepl.eu>
|
GH-8409 is a backport of this pull request to the 3.7 branch. |
|
GH-8410 is a backport of this pull request to the 3.6 branch. |
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851: IMAP MOVE Extension) and potentially as a name of supported method of IMAP4 object. (cherry picked from commit caa331d) Co-authored-by: Matěj Cepl <mcepl@cepl.eu>
|
GH-8411 is a backport of this pull request to the 2.7 branch. |
imaplib now allows MOVE command in IMAP4.uid() (RFC 6851: IMAP MOVE Extension) and potentially as a name of supported method of IMAP4 object. (cherry picked from commit caa331d) Co-authored-by: Matěj Cepl <mcepl@cepl.eu>
5 participants
Just checking whether this is a good idea at all. If so, I will add metadata required.
https://bugs.python.org/issue33336