bpo-33283: Mention PNG as a supported format by Tcl/Tk by andresdelfino · Pull Request #6479 · python/cpython

andresdelfino · 2018-04-15T14:23:54Z

https://bugs.python.org/issue33283

…5330

terryjreedy

I highly approve of adding the information.

terryjreedy · 2018-04-15T19:15:01Z

Doc/library/tkinter.rst

-* :class:`PhotoImage` can be used for GIF and PPM/PGM color bitmaps.
+* :class:`PhotoImage` can be used for GIF and PPM/PGM bitmaps. This class can
+  also be used for PNG bitmaps starting with Tcl/Tk 8.6.



I don't know why 'bitmap' is used for image files. Compressed files are not bitmaps as I understand the term. So I think this should say (without the markup)

class PhotoImage can be used with GIF and PPM/PGM files. PNG files can also be used, starting with Tcl/Tk 8.6.

Or replace 'file' with 'format' or 'data'.

What do you think about:

class PhotoImage can be used for GIF and PPM/PGM data. PNG data is also supported, starting with Tcl/Tk 8.6.

LGTM. Lets see when Serhiy thinks.

I would write something like: "... for images in PPM/PGM, GIF and PNG formats. The latter is only supported in Tk 8.6."

I agree. I'll update the PR.

Just a small change: "... for images in PPM/PGM, GIF and PNG formats. The latter is supported starting with Tk 8.6."

To be correct regarding the upcoming 8.7.

ok?

LGTM even better.

bedevere-bot · 2018-04-15T19:15:47Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

andresdelfino · 2018-04-15T21:58:35Z

I have made the requested changes; please review again

bedevere-bot · 2018-04-15T21:58:37Z

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

miss-islington · 2018-04-17T05:34:38Z

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

bedevere-bot · 2018-04-17T05:35:52Z

GH-6498 is a backport of this pull request to the 3.7 branch.

(cherry picked from commit 4b685bf) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

miss-islington · 2018-04-17T05:36:40Z

Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4b685bf7192fff48c8effeeae4f4d64f9420ec0f 2.7

(cherry picked from commit 4b685bf) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

bedevere-bot · 2018-04-17T05:37:45Z

GH-6499 is a backport of this pull request to the 3.6 branch.

(cherry picked from commit 4b685bf) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

miss-islington · 2018-04-18T17:28:21Z

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

bedevere-bot · 2018-04-18T17:28:41Z

GH-6521 is a backport of this pull request to the 3.7 branch.

(cherry picked from commit 4b685bf) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

serhiy-storchaka · 2018-04-18T18:17:41Z

Do you mind to make a backport to 2.7 @andresdelfino?

andresdelfino · 2018-04-18T18:20:21Z

Sure, @serhiy-storchaka !

Must I start a new pull request like I did for master? Based on 2.7, of course. I'm new to Git :P

serhiy-storchaka · 2018-04-18T18:50:52Z

You can use the cherry_picker command mentioned above: cherry_picker 4b685bf7192fff48c8effeeae4f4d64f9420ec0f 2.7.

It will fail due to conflicts. After resolving conflicts add modified files by git add and run cherry_picker --continue. This should open a web page for creating a new PR.

andresdelfino · 2018-04-18T20:04:55Z

Great! I'll fix an issue I'm having that prevents me from installing packages with pip, and I'll make the backport.

andresdelfino · 2018-04-20T01:53:23Z

I had problems following the cherry-picker path. Had to end the process manually, here's the PR:

#6542

Hope it helps.

…-6542) (cherry picked from commit 4b685bf) Update only the documentation about image formats.

bedevere-bot · 2018-04-22T15:54:58Z

GH-6542 is a backport of this pull request to the 2.7 branch.

Mention PNG as a supported format by Tcl/Tk

971651e

the-knights-who-say-ni added the CLA signed label Apr 15, 2018

bedevere-bot added the awaiting review label Apr 15, 2018

Specify which Tcl/Tk version supports PNG. Addresses msg315326, msg31…

4cb34c0

…5330

terryjreedy requested a review from serhiy-storchaka April 15, 2018 19:09

terryjreedy requested changes Apr 15, 2018

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Apr 15, 2018

andresdelfino added 2 commits April 15, 2018 18:37

Address PR comments

739a8d2

Final polishes

aefad5f

bedevere-bot added awaiting change review and removed awaiting changes labels Apr 15, 2018

terryjreedy approved these changes Apr 16, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Apr 16, 2018

serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir skip news labels Apr 17, 2018

serhiy-storchaka merged commit 4b685bf into python:master Apr 17, 2018

bedevere-bot removed awaiting merge needs backport to 3.7 labels Apr 17, 2018

bedevere-bot removed the needs backport to 3.6 label Apr 17, 2018

miss-islington added a commit that referenced this pull request Apr 17, 2018

bpo-33283: Mention PNG as a supported format by Tcl/Tk. (GH-6479)

f44ce35

(cherry picked from commit 4b685bf) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

andresdelfino deleted the tcltk_png branch April 17, 2018 10:35

serhiy-storchaka added the needs backport to 3.7 label Apr 18, 2018

bedevere-bot removed the needs backport to 3.7 label Apr 18, 2018

miss-islington added a commit that referenced this pull request Apr 18, 2018

bpo-33283: Mention PNG as a supported format by Tcl/Tk. (GH-6479)

b88f737

(cherry picked from commit 4b685bf) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

serhiy-storchaka pushed a commit that referenced this pull request Apr 20, 2018

bpo-33283: Mention PNG as a supported format by Tcl/Tk. (GH-6479) (GH…

7a45eb9

…-6542) (cherry picked from commit 4b685bf) Update only the documentation about image formats.

bedevere-bot removed the needs backport to 2.7 label Apr 22, 2018

Uh oh!

Conversation

andresdelfino commented Apr 15, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

terryjreedy Apr 15, 2018

Choose a reason for hiding this comment

Uh oh!

andresdelfino Apr 15, 2018

Choose a reason for hiding this comment

Uh oh!

terryjreedy Apr 15, 2018

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Apr 15, 2018

Choose a reason for hiding this comment

Uh oh!

andresdelfino Apr 15, 2018

Choose a reason for hiding this comment

Uh oh!

andresdelfino Apr 15, 2018

Choose a reason for hiding this comment

Uh oh!

terryjreedy Apr 15, 2018

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Apr 15, 2018

Uh oh!

andresdelfino commented Apr 15, 2018

Uh oh!

bedevere-bot commented Apr 15, 2018

Uh oh!

miss-islington commented Apr 17, 2018

Uh oh!

bedevere-bot commented Apr 17, 2018

Uh oh!

miss-islington commented Apr 17, 2018

Uh oh!

bedevere-bot commented Apr 17, 2018

Uh oh!

miss-islington commented Apr 18, 2018

Uh oh!

bedevere-bot commented Apr 18, 2018

Uh oh!

serhiy-storchaka commented Apr 18, 2018

Uh oh!

andresdelfino commented Apr 18, 2018

Uh oh!

serhiy-storchaka commented Apr 18, 2018

Uh oh!

andresdelfino commented Apr 18, 2018

Uh oh!

andresdelfino commented Apr 20, 2018

Uh oh!

bedevere-bot commented Apr 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

andresdelfino commented Apr 15, 2018 •

edited by bedevere-bot

Loading