Skip to content

bpo-33266: Add support for all string literals to lib2to3#6457

Merged
ambv merged 1 commit into
python:masterfrom
zsol:lib2to3-string-literals
Apr 16, 2018
Merged

bpo-33266: Add support for all string literals to lib2to3#6457
ambv merged 1 commit into
python:masterfrom
zsol:lib2to3-string-literals

Conversation

@zsol

@zsol zsol commented Apr 12, 2018

Copy link
Copy Markdown
Member

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@ambv

ambv commented Apr 16, 2018

Copy link
Copy Markdown
Contributor

Sigh, looks like we need to wait for the bot to update the signed CLA list.

@ned-deily

Copy link
Copy Markdown
Member

@ambv, It's not a bot problem. It's that the PSF administrators need to update the user entry in bugs.python.org (which causes the * to appear). That's a manual process. And, apparently, right now they aren't always being notified when someone submits a contributor agreement. Best to send email to contributors@python.org.

@ned-deily

ned-deily commented Apr 16, 2018

Copy link
Copy Markdown
Member

Of course, once the * appears then you will have a bot problem (and need to remove the CLA not signed label)!

@ambv ambv added the skip news label Apr 16, 2018
@ambv

ambv commented Apr 16, 2018

Copy link
Copy Markdown
Contributor

I'll add a NEWS entry in a separate PR.

@ambv
ambv merged commit 8f37e84 into python:master Apr 16, 2018
@bedevere-bot

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @zsol for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-6488 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2018
(cherry picked from commit 8f37e84)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
ambv pushed a commit that referenced this pull request Apr 16, 2018
(cherry picked from commit 8f37e84)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants