Skip to content

[3.7] Trivial dataclass cleanups: (GH-6218)#6219

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-f96ddad-3.7
Mar 24, 2018
Merged

[3.7] Trivial dataclass cleanups: (GH-6218)#6219
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-f96ddad-3.7

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor
  • When adding a single element to a list, use .append() instead of
    += and creating a new list.
  • For consistency, import the copy module, instead of just deepcopy. This
    leaves only a module at the class level, instead of a function.
  • Improve some comments.
  • Improve some whitespace.
  • Use tuples instead of lists.
  • Simplify a test.
    (cherry picked from commit f96ddad)

Co-authored-by: Eric V. Smith ericvsmith@users.noreply.github.com

- When adding a single element to a list, use .append() instead of
  += and creating a new list.
- For consistency, import the copy module, instead of just deepcopy. This
  leaves only a module at the class level, instead of a function.
- Improve some comments.
- Improve some whitespace.
- Use tuples instead of lists.
- Simplify a test.
(cherry picked from commit f96ddad)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@ericvsmith: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 02c19a6 into python:3.7 Mar 24, 2018
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-f96ddad-3.7 branch March 24, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants